Skip to content

Conversation

@rmkaplan
Copy link
Contributor

This makes sure that the promptwindow is attached as the last thing when a window is set up for a Tedit document. This also ensures that Tedit windows always have titles.

If a title-less window (as opposed to a region or NIL) is given as the WINDOW argument to TEDIT or OPENTEXTSTREAM, a title is constructed and installed first, before the prompt window is attached.

This should eliminate the odd behavior reported in #2363.

However, Tedit windows are not guaranteed to be subtractive, in the sense discussed there, so the title and/or promptwindow may show up above the region provided by the user. There is a conceptual confusion as to whether what the user specifies is the region of the final window constellation (with title and promptwindow) or the region of the text area of the window (the clipping region without title or promptwindow). The former is subtractive, the latter is additive.

This interacts with the heuristics for suggesting a default size for a window based on properties of the document that it is going to display--those heuristics calculate the text region, assume an additive model.

@pamoroso
Copy link
Contributor

In my initial tests the change works as expected. I checked out Insphex, DInfo, NoteCards, and the example in issue #2363.

Copy link
Contributor

@pamoroso pamoroso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works with no issues in my testing.

@rmkaplan rmkaplan merged commit 9d28090 into master Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants