-
Notifications
You must be signed in to change notification settings - Fork 47
feat: Add DNA and RNA search functionality #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ChenZiHong-Gavin
merged 26 commits into
Intern-Science:main
from
CHERRY-ui8:feat/add-dna-rna-search
Dec 1, 2025
Merged
feat: Add DNA and RNA search functionality #105
ChenZiHong-Gavin
merged 26 commits into
Intern-Science:main
from
CHERRY-ui8:feat/add-dna-rna-search
Dec 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add NCBISearch searcher for DNA/GenBank/Entrez database search - Add RNACentralSearch searcher for RNA database search - Update search_all.py to support ncbi and rnacentral data sources - Add search configs for DNA, RNA, and protein (renamed from search_config) - Add search scripts for DNA and RNA - Add demo input files for DNA and RNA search - Update search_uniprot.sh to use search_protein_config.yaml This PR extends the search functionality to support biological data types: - Protein search (existing, now explicitly named) - DNA search via NCBI - RNA search via RNAcentral
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
- Remove all trailing whitespace - Fix line-too-long issues (split long lines) - Remove trailing newlines at end of files - Remove unnecessary else/elif after return statements
…Gen into feat/add-dna-rna-search
- Extract utility functions (_gene_record_to_dict, _accession_to_dict, _rna_data_to_dict) - Unify method naming: search_by_keyword -> get_best_hit - Add threshold parameter to NCBI and RNAcentral searchers for interface consistency - Improve error handling with network error detection and fallback strategies - Fix RNAcentral sequence search to prioritize exact matches - Add search_rna_demo.jsonl example file
…Gen into feat/add-dna-rna-search
f1bca32 to
8678e33
Compare
6016dfe to
40ef49e
Compare
- Refactor search_by_sequence in ncbi_searcher.py to reduce return statements from 7 to 1 - Refactor search_by_sequence in rnacentral_searcher.py to reduce return statements from 8 to 1 and branches from 16 to 12 - Extract helper methods to improve code readability and maintainability - Fix pylint errors R0911 (too-many-return-statements) and R0912 (too-many-branches)
bfa8a2f to
d767096
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the search functionality to support biological data types: