fix: move quantized norm to CPU instead of stale q_linear reference in smooth_quant#4352
Merged
lvhan028 merged 1 commit intoInternLM:mainfrom Feb 12, 2026
Merged
Conversation
lvhan028
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lmdeploy/lite/apis/smooth_quant.pywhere the norm quantization loop callsq_linear.to('cpu')instead ofq_norm.to('cpu')q_linearis a stale variable from the previous linear quantization loop, so the quantizedQRMSNormobjects are never moved to CPUDetails
In the
smooth_quantfunction, there are two quantization loops:q_linear.to('cpu')after quantizing each linear layerq_normviaQRMSNorm.from_float()but then callsq_linear.to('cpu')(copy-pasted from the linear loop) instead ofq_norm.to('cpu')The fix is a one-line change:
q_linear.to('cpu')->q_norm.to('cpu')in the norm quantization loop.Test plan