log reponse for debugging#4592
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds request response logging to the async generation path for debugging, extending the existing request logging utility.
Changes:
- Collects generated response chunks during async generation.
- Adds
RequestLogger.log_response()to emit the generated response at request log level.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
lmdeploy/serve/core/async_engine.py |
Collects generated chunks and logs the response after generation. |
lmdeploy/logger.py |
Adds response logging support to RequestLogger. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| output_len, gen_len = 0, 0 | ||
| state = DetokenizeState(input_len) | ||
| response = '' | ||
| response_chunks = [] |
CUHKSZzxy
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.