[Fix] Fix missing post_micro_batch_forward invocation in vl model#1806
Merged
HAOCHENYE merged 1 commit intoMay 20, 2026
Merged
Conversation
Collaborator
Author
|
@claude review |
Contributor
|
Claude: ## Summary Clean, correct fix. The The fix delegates to VerdictAPPROVE |
1f8ba8f to
c634fdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently vl base model does not override
post_micro_batch_fowardmethod, meaning that they inherit the behavior fromBaseModeldirectly. When one trains a vl model with MoE text part, this would cause:maxviofrom tracking logs;NoAuxRouteris used, the bias would never be updated.This PR fixes this issue.