Skip to content

Conversation

@ChenZiHong-Gavin
Copy link
Collaborator

@ChenZiHong-Gavin ChenZiHong-Gavin commented Jan 27, 2026

This PR expands the project's test coverage by introducing a variety of new end-to-end tests for core functionalities like knowledge graph evaluation, question-answering evaluation, and different question generation methods.

@github-actions github-actions bot added documentation Improvements or additions to documentation core examples webui tests labels Jan 27, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ChenZiHong-Gavin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the project's test coverage by introducing a variety of new end-to-end tests for core functionalities like knowledge graph evaluation, question-answering evaluation, and different question generation methods. Concurrently, it undertakes a substantial refactoring of the project's internal file structure, relocating image assets to a dedicated directory and reorganizing NLTK data, which required corresponding updates in documentation and configuration files. These changes aim to improve the robustness and maintainability of the codebase.

Highlights

  • New End-to-End Tests: A comprehensive suite of new end-to-end tests has been added to cover various functionalities including KG evaluation, QA evaluation, schema-guided extraction, and different types of question generation (fill-in-blank, multi-answer, multi-choice, true/false).
  • Test File Restructuring: Existing end-to-end tests have been reorganized into logical subdirectories under tests/e2e_tests/generate/ and new tests are added under tests/e2e_tests/evaluate/ and tests/e2e_tests/extract/, improving test organization and maintainability. This also involved updating import paths within these test files.
  • Resource Path Refactoring: Image assets (logo and workflow diagram) have been relocated from resources/images/ to a new assets/ directory. This change is reflected across README.md, README_zh.md, .github/sync-config.yml, and webui/app.py.
  • NLTK Data Relocation: Several NLTK data files, including stopwords and punkt tokenizer data, have been moved from the top-level resources/nltk_data/ to graphgen/resources/nltk_data/.
  • Evaluation Configuration Update: Two metrics, qa_reward_score and qa_uni_score, have been commented out in the qa_evaluation_config.yaml example.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ChenZiHong-Gavin
Copy link
Collaborator Author

/gemini review

@ChenZiHong-Gavin ChenZiHong-Gavin merged commit d0df8f0 into main Jan 27, 2026
8 checks passed
@ChenZiHong-Gavin ChenZiHong-Gavin deleted the tests/add-tests branch January 27, 2026 15:42
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive suite of end-to-end tests for various generation and evaluation configurations, significantly improving test coverage. The changes include adding new test files, reorganizing existing ones into more logical subdirectories (generate and evaluate), and updating import paths from relative to absolute, which enhances code clarity and maintainability. Additionally, image asset paths across the repository have been updated from resources/images to assets, ensuring consistency in resource management. The commenting out of qa_reward_score and qa_uni_score in qa_evaluation_config.yaml is noted as a functional change in the evaluation setup.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully expands the project's test coverage by introducing new end-to-end tests for various core functionalities, including knowledge graph evaluation, question-answering evaluation, and different question generation methods. The changes also involve a consistent refactoring of resource paths from resources/images to assets across configuration files, READMEs, and the web UI, which improves the project's asset management. Additionally, the import statements in the renamed test files have been updated to use absolute paths, enhancing code clarity and maintainability. Overall, these changes are well-implemented and contribute positively to the project's robustness and organization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core documentation Improvements or additions to documentation examples tests webui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants