-
Notifications
You must be signed in to change notification settings - Fork 67
tests: add e2e tests #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add e2e tests #167
Conversation
Summary of ChangesHello @ChenZiHong-Gavin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the project's test coverage by introducing a variety of new end-to-end tests for core functionalities like knowledge graph evaluation, question-answering evaluation, and different question generation methods. Concurrently, it undertakes a substantial refactoring of the project's internal file structure, relocating image assets to a dedicated directory and reorganizing NLTK data, which required corresponding updates in documentation and configuration files. These changes aim to improve the robustness and maintainability of the codebase. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a comprehensive suite of end-to-end tests for various generation and evaluation configurations, significantly improving test coverage. The changes include adding new test files, reorganizing existing ones into more logical subdirectories (generate and evaluate), and updating import paths from relative to absolute, which enhances code clarity and maintainability. Additionally, image asset paths across the repository have been updated from resources/images to assets, ensuring consistency in resource management. The commenting out of qa_reward_score and qa_uni_score in qa_evaluation_config.yaml is noted as a functional change in the evaluation setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully expands the project's test coverage by introducing new end-to-end tests for various core functionalities, including knowledge graph evaluation, question-answering evaluation, and different question generation methods. The changes also involve a consistent refactoring of resource paths from resources/images to assets across configuration files, READMEs, and the web UI, which improves the project's asset management. Additionally, the import statements in the renamed test files have been updated to use absolute paths, enhancing code clarity and maintainability. Overall, these changes are well-implemented and contribute positively to the project's robustness and organization.
This PR expands the project's test coverage by introducing a variety of new end-to-end tests for core functionalities like knowledge graph evaluation, question-answering evaluation, and different question generation methods.