Skip to content

Conversation

@ChrisCoxArt
Copy link
Contributor

Fixes #216

Fixes #216
But waiting for input from Max about this - was it a mistake, or by design?
@xsscx xsscx self-requested a review November 24, 2025 22:56
@xsscx xsscx self-assigned this Nov 24, 2025
@xsscx xsscx added Bug Bug Report PR Pull Request Review in Process PR being Reviewed by Maintainers ci labels Nov 24, 2025
@xsscx xsscx changed the title fix copy constructors for CIccTagSpectralViewingConditions Fix: CIccTagSpectralViewingConditions::CIccTagSpectralViewingConditions() UB Nov 24, 2025
Copy link
Member

@xsscx xsscx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR 225 Repro

          export CXX=clang++
          git clone https://github.com/InternationalColorConsortium/iccDEV.git
          cd iccDEV
          git fetch origin pull/225/head:pr-225
          git checkout pr-225
          cd Build
          cmake -DCMAKE_INSTALL_PREFIX=$HOME/.local -DCMAKE_BUILD_TYPE=Debug -Wno-dev -DCMAKE_CXX_FLAGS="-g -fsanitize=address,undefined -fno-omit-frame-pointer -Wall" -DENABLE_TOOLS=ON -DENABLE_STATIC_LIBS=ON -DENABLE_SHARED_LIBS=ON Cmake/
          make -j$(nproc)
          echo "========= BEGIN INSIDE STUB for Issue 216 ========="
          cd ../Testing/
          echo "=== Updating PATH ==="
           for d in ../Build/Tools/*; do
            [ -d "$d" ] && export PATH="$(realpath "$d"):$PATH"
           done
          echo "========= fetching the profile... =========" 
          wget https://github.com/xsscx/Commodity-Injection-Signatures/raw/refs/heads/master/graphics/icc/Cat8Lab-D65_2degMeta.icc
          iccRoundTrip Cat8Lab-D65_2degMeta.icc

Expected Output

2025-11-24 18:07:45 (12.7 MB/s) - ‘Cat8Lab-D65_2degMeta.icc’ saved [2600/2600]

Profile:          'Cat8Lab-D65_2degMeta.icc'
Rendering Intent: Relative Colorimetric
Specified Gamut:  Not Specified

Round Trip 1
------------
Min DeltaE:        0.00
Mean DeltaE:       0.00
Max DeltaE:        0.00

Max L, a, b:   0.000000, -128.000000, -128.000000

Round Trip 2
------------
Min DeltaE:        0.00
Mean DeltaE:       0.00
Max DeltaE:        0.00

Max L, a, b:   0.000000, -128.000000, -128.000000

PRMG Interoperability - Round Trip Results
------------------------------------------------------
DE <= 1.0 (  201613): 100.0%
DE <= 2.0 (  201613): 100.0%
DE <= 3.0 (  201613): 100.0%
DE <= 5.0 (  201613): 100.0%
DE <=10.0 (  201613): 100.0%
Total     (  201613)

The above Test indicates that PR225 resolves Issue 216 and this PR will be Merged.

Thank You @ChrisCoxArt for your time & efforts!
PR225 addressed the UB in CIccTagSpectralViewingConditions::CIccTagSpectralViewingConditions() reported from Issue 216
Signed-off-by: D Hoyt xss@xss.cx

@xsscx xsscx added Merged Merged and removed Bug Bug Report Review in Process PR being Reviewed by Maintainers ci labels Nov 24, 2025
@xsscx xsscx changed the title Fix: CIccTagSpectralViewingConditions::CIccTagSpectralViewingConditions() UB Fix: CIccTagSpectralViewingConditions() UB Nov 24, 2025
@xsscx xsscx merged commit c675fb4 into master Nov 24, 2025
3 checks passed
@ChrisCoxArt ChrisCoxArt deleted the issue-216 branch November 25, 2025 04:59
@xsscx xsscx added the Security Security Related label Nov 25, 2025
@xsscx
Copy link
Member

xsscx commented Jan 3, 2026

GHSA-fg9m-j9x8-8279

@xsscx xsscx added the CVE Requested Maintainer indicates a CVE has been Requested label Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CVE Requested Maintainer indicates a CVE has been Requested Merged Merged PR Pull Request Security Security Related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Known Defect: runtime error: -nan is outside the range of representable values of type 'int' | IccProfLib/IccUtil.cpp:555

3 participants