Bugfix/memory leaks#3
Merged
maxderhak merged 7 commits intoInternationalColorConsortium:masterfrom Dec 30, 2015
Merged
Conversation
added 7 commits
December 29, 2015 10:25
…n pSBuf==nullptr)
xsscx
added a commit
that referenced
this pull request
Dec 19, 2025
## Expected Output
```
=================================================================
==12==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x5080000970fc at pc 0x5a276a07d982 bp 0x7ffd93795080 sp 0x7ffd93795078
READ of size 2 at 0x5080000970fc thread T0
#0 0x5a276a07d981 in CIccLocalizedUnicode::GetText(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>&) /src/ipatch/IccProfLib/IccTagBasic.cpp:7131:10
#1 0x5a276a081de1 in CIccTagMultiLocalizedUnicode::Describe(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>&, int) /src/ipatch/IccProfLib/IccTagBasic.cpp:7678:8
#2 0x5a276a016ad0 in LLVMFuzzerTestOneInput /src/ipatch/fuzzers/icc_profile_fuzzer.cpp:57:14
#3 0x5a2769f22b14 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) (/fuzzers/address/icc_profile_fuzzer+0x133b14) (BuildId: 69d65da2322bfc3aabf2fe513f6ed3b459b59ad6)
#4 0x5a2769f221d9 in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long, bool, fuzzer::InputInfo*, bool, bool*) (/fuzzers/address/icc_profile_fuzzer+0x1331d9) (BuildId: 69d65da2322bfc3aabf2fe513f6ed3b459b59ad6)
#5 0x5a2769f23ae5 in fuzzer::Fuzzer::MutateAndTestOne() (/fuzzers/address/icc_profile_fuzzer+0x134ae5) (BuildId: 69d65da2322bfc3aabf2fe513f6ed3b459b59ad6)
#6 0x5a2769f24675 in fuzzer::Fuzzer::Loop(std::vector<fuzzer::SizedFile, std::allocator<fuzzer::SizedFile>>&) (/fuzzers/address/icc_profile_fuzzer+0x135675) (BuildId: 69d65da2322bfc3aabf2fe513f6ed3b459b59ad6)
#7 0x5a2769f1219a in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) (/fuzzers/address/icc_profile_fuzzer+0x12319a) (BuildId: 69d65da2322bfc3aabf2fe513f6ed3b459b59ad6)
#8 0x5a2769f3ae86 in main (/fuzzers/address/icc_profile_fuzzer+0x14be86) (BuildId: 69d65da2322bfc3aabf2fe513f6ed3b459b59ad6)
#9 0x78827edb6574 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x2a574) (BuildId: 6eb17b070ada6b3046d26d07559366a4d899b8f7)
#10 0x78827edb6627 in __libc_start_main (/usr/lib/x86_64-linux-gnu/libc.so.6+0x2a627) (BuildId: 6eb17b070ada6b3046d26d07559366a4d899b8f7)
#11 0x5a2769f07294 in _start (/fuzzers/address/icc_profile_fuzzer+0x118294) (BuildId: 69d65da2322bfc3aabf2fe513f6ed3b459b59ad6)
```
xsscx
pushed a commit
that referenced
this pull request
Apr 5, 2026
- Add patch #3: disable IccIisIsapi subdirectory (IIS SDK not available in vcpkg, and ISAPI DLLs are not library distribution targets) - Remove stray dependency DLLs (libiconv, libxml2, zlib) that cmake installs alongside tools, conflicting with their own vcpkg ports - Renumber source patches 3-9 to 4-10 Fixes: manifest-test job failure in ci-vcpkg-ports.yml Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some errors with memory.
I seen some additional points, like allocating memory with new and deleting with free, but to clean up this we need to discuss first if we will unify all memory operations and if we will use c++11.