Skip to content

Fix: Type Confusion in CIccSegmentedCurveXml::ToXml() & ToXmlCurve() at IccXML/IccLibXML/IccMpeXml.cpp #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xsscx merged 3 commits into from
Jan 4, 2026
Merged

Fix: Type Confusion in CIccSegmentedCurveXml::ToXml() & ToXmlCurve() at IccXML/IccLibXML/IccMpeXml.cpp #432

xsscx merged 3 commits into from
Jan 4, 2026
+37 −18

Conversation

@ChrisCoxArt
Copy link
Contributor

@ChrisCoxArt ChrisCoxArt commented Jan 4, 2026

Create copy constructors to make child classes from parent class.
Cast generic pointer to specific type pointer,
then copy instead of type punning (casting) to get child class.
Fix a misnamed CIccSingleSampledeCurveXml class along the way.
Fixes #388, #389, #390

Pull Request Checklist

  • Have you followed the guidelines in Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you built your Pull Request locally with the Build Instructions?
  • Have you added or updated relevant tests?
  • Have you added or updated relevant docs?

@ChrisCoxArt
Create copy constructors from base class
ab6f24a 
Give XML classes a way to convert from base classes.
copy base class to child class instead of type punning (and hoping).
Current dynamic_cast while I keep testing.
Checking in debug state because I don't want to lose this.
@ChrisCoxArt
cleanup constructors
b03add1 
reduce constructors on types that didn't need them.
@ChrisCoxArt
cleanup, remove debugging safety code
5fac9e4 
remove the extra safety after doing some testing
@ChrisCoxArt ChrisCoxArt requested a review from xsscx as a code owner January 4, 2026 22:20
@xsscx xsscx self-assigned this Jan 4, 2026
@xsscx xsscx added PR Pull Request Review in Process PR being Reviewed by Maintainers labels Jan 4, 2026
xsscx
xsscx approved these changes Jan 4, 2026
View reviewed changes
Copy link
Member

@xsscx xsscx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sun Jan 4 10:36:33 PM UTC 2026

@xsscx xsscx added the Pending Merge Maintainer indicates Merge Pending and requests no further changes label Jan 4, 2026
@xsscx xsscx changed the title Fix bad type casting in XML curve writing Fix: Type Confusion in CIccSegmentedCurveXml::ToXml() & ToXmlCurve() at IccXML/IccLibXML/IccMpeXml.cpp Jan 4, 2026
@xsscx xsscx added Security Security Related Pending Merge Maintainer indicates Merge Pending and requests no further changes and removed Pending Merge Maintainer indicates Merge Pending and requests no further changes Review in Process PR being Reviewed by Maintainers labels Jan 4, 2026
@xsscx xsscx merged commit 024b7af into master Jan 4, 2026
27 checks passed
@xsscx xsscx added Merged Merged and removed Pending Merge Maintainer indicates Merge Pending and requests no further changes labels Jan 4, 2026
@xsscx
Copy link
Member

xsscx commented Jan 4, 2026

GHSA-7662-mf46-wr88
#388

@xsscx xsscx added the CVE Requested Maintainer indicates a CVE has been Requested label Jan 4, 2026
@xsscx
Copy link
Member

xsscx commented Jan 4, 2026

GHSA-v3q7-7hw6-6jq8
#389

@xsscx xsscx linked an issue Jan 6, 2026 that may be closed by this pull request
TC in CIccSegmentedCurveXml::ToXml() at IccXML/IccLibXML/IccMpeXml.cpp:976:49 #389
Closed
@ChrisCoxArt ChrisCoxArt deleted the issue-388 branch January 7, 2026 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xsscx xsscx xsscx approved these changes

Assignees

@xsscx xsscx

Labels

CVE Requested Maintainer indicates a CVE has been Requested Merged Merged PR Pull Request Security Security Related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TC in CIccSegmentedCurveXml::ToXml() at IccXML/IccLibXML/IccMpeXml.cpp:976:49 TC in ToXmlCurve() at IccXML/IccLibXML/IccMpeXml.cpp:1038:36

3 participants

@ChrisCoxArt @xsscx