Fix: heap-buffer-overflow in SIccCalcOp::Describe() at IccProfLib/IccMpeCalc.cpp #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix limit on number of ops add notes about if else ops counts probably being wrong. Select may be wrong as well, but harder to figure out. Fixes #454
xsscx
added
PR
xsscx
changed the title
xsscx
approved these changes
Jan 7, 2026
Member
There was a problem hiding this comment.
2026-01-07 02:52:40 (70.4 MB/s) - ‘SIccCalcOp-Describe-IccProfLib-IccMpeCalc_cpp_L1816.icc’ saved [3936/3936]
xss@W5:~/pr459/iccDEV/Testing$ iccToXml SIccCalcOp-Describe-IccProfLib-IccMpeCalc_cpp_L1816.icc SIccCalcOp-Describe-IccProfLib-IccMpeCalc_cpp_L1816.xml
XML successfully created
xss@W5:~/pr459/iccDEV/Testing$ git rev-parse HEAD && git show --no-patch --oneline
1d649dbf833015e0416894d479b6affbd24253d7
1d649db (HEAD -> pr-459, origin/issue-454) fix buffer overread in CIccCalculatorFunc::DescribeSequence
xss@W5:~/pr459/iccDEV/Testing$ date
Wed Jan 7 02:53:36 AM UTC 2026
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix limit on number of ops.
add notes about if else ops counts probably being wrong.
Select may be wrong as well, but harder to figure out.
Fixes #454
Pull Request Checklist