Skip to content

Fix: alloc-dealloc-mismatch#693

Merged
xsscx merged 1 commit intomasterfrom
issue-690
Mar 15, 2026
Merged

Fix: alloc-dealloc-mismatch#693
xsscx merged 1 commit intomasterfrom
issue-690

Conversation

@ChrisCoxArt
Copy link
Contributor

Fixes 690

Pull Request Checklist

  • Have you followed the guidelines in Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you built your Pull Request locally with the Build Instructions?
  • Have you added or updated relevant tests?
  • Have you added or updated relevant docs?

@ChrisCoxArt ChrisCoxArt requested a review from xsscx as a code owner March 15, 2026 02:12
@xsscx xsscx self-assigned this Mar 15, 2026
@xsscx xsscx added PR Pull Request Review in Process Issue is being Reviewed by Maintainers and removed pending labels Mar 15, 2026
Copy link
Member

@xsscx xsscx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer Review

2026-03-15 02:19:00 UTC

Repro

mkdir pr-693
cd pr-693
git clone https://github.com/InternationalColorConsortium/iccDEV.git
cd iccDEV/Build
git fetch origin pull/693/head:pr-693
git checkout pr-693
export CXX=clang++ && export CXXFLAGS="-fsanitize=address,undefined -fno-omit-frame-pointer -g -O1 -fprofile-arcs -ftest-coverage" && export LDFLAGS="-fsanitize=address,undefined -fprofile-arcs" && cmake Cmake -DCMAKE_BUILD_TYPE=Debug -DENABLE_ASAN=ON -DENABLE_UBSAN=ON -DENABLE_COVERAGE=ON
make -j$(nproc)
        cd ../Testing/
        echo "=== Updating PATH ==="
         for d in ../Build/Tools/*; do
          [ -d "$d" ] && export PATH="$(realpath "$d"):$PATH"
         done
wget https://github.com/xsscx/fuzz/raw/refs/heads/master/graphics/tif/hbo-CTiffImg-WriteLine-TiffImg_cpp-Line411.tif
wget https://github.com/xsscx/fuzz/raw/refs/heads/master/graphics/icc/hbo-CTiffImg-WriteLine-TiffImg_cpp-Line411.icc
ASAN_OPTIONS=print_scariness=1 iccSpecSepToTiff hbo-CTiffImg-WriteLine-TiffImg_cpp-Line411.icc 0 0 hbo-CTiffImg-WriteLine-TiffImg_cpp-Line411.tif 0 0 1 

PR Application Output

[2026-03-15 02:18:26 UTC] ~/pr-693/iccDEV/Testing (pr-693)$ git log --oneline --graph -1
* 34b8e5c (HEAD -> pr-693, origin/issue-690) make sure unique_ptr has [] for arrays
[2026-03-15 02:18:47 UTC] ~/pr-693/iccDEV/Testing (pr-693)$ ASAN_OPTIONS=print_scariness=1 iccSpecSepToTiff hbo-CTiffImg-WriteLine-TiffImg_cpp-Line411.icc 0 0 hbo-CTiffImg-WriteLine-TiffImg_cpp-Line411.tif 0 0 1
TIFFReadDirectory: Warning, Unknown field with tag 14645 (0x3935) encountered.
TIFFFetchNormalTag: Warning, Incorrect count for "PhotometricInterpretation"; tag ignored.
_TIFFVSetField: hbo-CTiffImg-WriteLine-TiffImg_cpp-Line411.tif: Bad value 69 for "ResolutionUnit" tag.
TIFFFetchNormalTag: Defined set_field_type of custom tag 14645 (Tag 14645) is TIFF_SETGET_UNDEFINED and thus tag is not read from file.
TIFFReadDirectory: Warning, Bogus "StripByteCounts" field, ignoring and calculating from imagelength.
Image successfully written!

@xsscx xsscx added Pending Merge Maintainer indicates Merge Pending and requests no further changes and removed Review in Process Issue is being Reviewed by Maintainers labels Mar 15, 2026
@xsscx xsscx changed the title make sure unique_ptr has [] for arrays Fix: alloc-dealloc-mismatch Mar 15, 2026
@xsscx xsscx linked an issue Mar 15, 2026 that may be closed by this pull request
@xsscx xsscx merged commit 8e3f701 into master Mar 15, 2026
27 checks passed
@xsscx xsscx removed the Pending Merge Maintainer indicates Merge Pending and requests no further changes label Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

alloc-dealloc-mismatch in iccSpecSepToTiff.cpp

2 participants