Conversation
ChrisCoxArt
approved these changes
Mar 29, 2026
Closed
xsscx
added
Pending Merge
xsscx
force-pushed
the
fix-code-coreguidelines
branch
from
bd8b874 to
b2c164f
Compare
xsscx
force-pushed
the
fix-code-coreguidelines
branch
from
b2c164f to
9d466f7
Compare
ChrisCoxArt
approved these changes
Mar 29, 2026
xsscx
force-pushed
the
fix-code-coreguidelines
branch
from
8366cc3 to
6a99f9d
Compare
Member
Author
|
@ChrisCoxArt Thank You!! Getting better data outputs |
xsscx
force-pushed
the
fix-code-coreguidelines
branch
from
6a99f9d to
c974506
Compare
Member
Author
Workflows: - ci-latest-release.yml: add push-to-master trigger, rolling 'latest' GitHub Release with zipped artifacts for all 3 platforms, restrict top-level permissions to contents: read (release job has write) - ci-pr-win.yml: governance-harden all pwsh steps with full flags, POWERSHELL_UPDATECHECK, PSDefaultParameterValues Static analysis (cppcheck / scan-build): - IccMpeBasic.cpp: fix self-assignment bug in CIccMpeCurveSet::operator= (m_nReserved = m_nReserved -> curveSet.m_nReserved) - IccMpeBasic.cpp: add self-assignment guards to operator= in CIccMpeMatrix, CIccMpeJabToXYZ, CIccMpeXYZToJab (use-after-free) - IccMpeBasic.cpp: initialize missing members in constructors and operator= for CIccSampledCurveSegment (m_range, m_last), CIccSingleSampledCurve (m_range, m_last), CIccSampledCalculatorCurve (m_storageType, m_range, m_last, m_nDesiredSize, m_pCalc NULL fallback), CIccMpeMatrix (m_type, m_bApplyConstants) - IccCmm.cpp: add assert(last != NULL) for scan-build false positive - IccProfileXml.cpp: add missing break in switch statement - IccUtilXml.cpp: fix sscanf format specifiers (%d -> %u for unsigned) - IccUtilXml.cpp: use long double intermediary in clipTypeRange to avoid implicit conversion warnings Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
xsscx
force-pushed
the
fix-code-coreguidelines
branch
from
c974506 to
b3365c4
Compare
Member
Author
Code Coverage Comparison2026-03-29 04:44:39 UTC
IntentMerge |
xsscx
removed
Pending Merge
This was referenced Apr 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
#757