Conversation
…, and CI improvements Separation of concerns: - Extract IccIsapiSanitize.h/.cpp — sanitization primitives (HtmlEscape, JsonEscape, SanitizeFilename, SanitizeUri, UrlDecode, SanitizeErrorMessage) - Extract IccIsapiHttp.h/.cpp — HTTP response layer with 7 security headers (CSP, X-Frame-Options, X-Content-Type-Options, X-XSS-Protection, Cache-Control, Referrer-Policy, Content-Length) - Refactor iccIisIsapi.cpp to use extracted modules Security hardening: - UrlDecode: replace std::stoi() with manual hex conversion (CWE-248) - SanitizeErrorMessage: scrub all path patterns from error output (CWE-209) - BuildPlainTextBody: replace fixed buffer with ostringstream - BuildToolSuiteResponse: add workspace cleanup in catch block (CWE-789) - Add SanitizeUri() for URI path sanitization - Add sanitize.js for client-side DOM-XSS prevention - Add format=json endpoint returning valid JSON Testing and tooling: - IccIsapiFuzzTest.cpp — fuzz test harness (54,055 checks, 0 failures) - Stress-IccIisIsapi.ps1 — concurrent stress test (1,762 RPS) - Uninstall-IccIisIsapiSite.ps1 — clean IIS teardown - Export/Import-IccIisIsapiSite.ps1 — deployment packaging CI workflow fix: - ci-pr-risk-security-analysis.yml Check 7: broaden write permission detection to all scopes (packages, pull-requests, issues, actions, security-events) in both Linux and Windows audit jobs Documentation: Updated AGENTS.md, copilot-instructions.md, Readme.md, isapi-instructions.md with ISAPI architecture and deployment guides. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Apr 6, 2026
Merged
ChrisCoxArt
approved these changes
Apr 6, 2026
xsscx
added
Pending Merge
…tics - sanitize-sed.sh v4: detect_hidden_chars() (8 categories), validate_ref() - sanitize.ps1 v4: Detect-HiddenChars, Validate-Ref (PowerShell parity) - ci-pr-risk-security-analysis.yml: Section 6 table output, Section 10 canary check (PR #786 BOM pattern), emit_ref_finding() with hex dump - ci-pr-action.yml: ref validation using detect_hidden_chars - test_sanitization.sh: version v3->v4 fix, grep pipefail guard Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
xsscx
removed
Pending Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
#784