Fix/atrribute error crash when no postal info supplied#265
Merged
ehsan-fj merged 2 commits intoInternetNZ:developfrom Mar 10, 2026
Merged
Conversation
Contributor
Author
|
Linting: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
AttributeErrorinContact.update()whenpostal_info=NoneProblem
Calling
Contact.update()with aContactDatawherepostal_infoisNone(the default) raised anAttributeErrorin two places:_data_to_dict()— called.pop("address", {})directly onpostal_infowithout guarding againstNoneupdate()— accessedcontact.postal_info.addressunconditionally when computingaddress_changeChanges
pyepp/contact.py_data_to_dict: guardpostal_info.pop(...)withif postal_info is not Noneupdate: use short-circuit evaluationbool(contact.postal_info and contact.postal_info.address)foraddress_changetests/test_contact.pytest_data_to_dict_without_postal_info— verifies_data_to_dicthandlespostal_info=Nonewithout crashing and omits postal fields from the resulttest_update_without_postal_info— regression test assertingpostalinfo_change=Falseandaddress_change=Falseare passed toexecutewhenpostal_info=Nonetest_updateto assertpostalinfo_change=Trueis passed toexecute