Use enums instead of defines for synth settings

[oreo639]

I feel this is a cleaner way of doing it. If you disagree, let me know.

[HunterZ]

I like your enum solution better, although it's less consistent with the rest of the codebase.

[oreo639]

Yeah.
Also, what's with

make[1]: *** [CMakeFiles/systemshock.dir/rule] Error 2
make: *** [systemshock] Error 2

[HunterZ]

@oreo639 I see two errors:

In file included from /Users/travis/build/Interrupt/systemshock/build_ext/fluidsynth-lite/src/utils/fluid_sys.c:24:
/Users/travis/build/Interrupt/systemshock/build_ext/fluidsynth-lite/src/utils/apple/timing_mach.h:22:6: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
#if (TIMING_MACH_BEFORE_10_12)
     ^
/Users/travis/build/Interrupt/systemshock/build_ext/fluidsynth-lite/src/utils/apple/timing_mach.h:9:35: note: expanded from macro 'TIMING_MACH_BEFORE_10_12'
#define TIMING_MACH_BEFORE_10_12 (defined(__MACH__) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101200)
                                  ^
1 error generated.

...and...

/Users/travis/build/Interrupt/systemshock/src/GameSrc/wrapper.c:373:14: error: use of undeclared identifier 'REF_STR_FluidSyn'
        case REF_STR_FluidSyn: return "FluidSynth";
             ^

[oreo639]

I see two errors:

First one seems like it is unrelated to my pr.
Second one, you are right. My bad, I forgot to do that.

[Interrupt]

Looks like this has a merge conflict now, @oreo639 want to fix?

[oreo639]

Thanks for reminding me.