Add Conway governance constraints to experimental constraints#1189
Open
carbolymer wants to merge 1 commit intomasterfrom
Open
Add Conway governance constraints to experimental constraints#1189carbolymer wants to merge 1 commit intomasterfrom
carbolymer wants to merge 1 commit intomasterfrom
Conversation
carbolymer
requested review from
CarlosLopezDeLara,
Jimbo4350,
disassembler,
erikd and
palas
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Conway governance-related ledger constraints into the experimental era constraint bundle so governance functionality can be used under EraCommonConstraints without additional Conway-specific constraint wrappers.
Changes:
- Import Conway governance/state ledger modules needed to reference governance constraints in the experimental era layer.
- Extend
EraCommonConstraintswithConwayEraGov,ConwayEraCertState, andGovState ~ ConwayGovStateequality. - Add a changelog fragment describing the API surface change.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
cardano-api/src/Cardano/Api/Experimental/Era.hs |
Extends the exported experimental common constraint set to include Conway governance constraints. |
.changes/20260424_cardano_api_add_conway_gov_to_common_constraints.yml |
Documents the change for release notes (but needs metadata/kind adjustments). |
carbolymer
force-pushed
the
mgalazyn/feature/add-conway-gov-to-common-constraints
branch
from
b890a10 to
dddeb59
Compare
carbolymer
force-pushed
the
mgalazyn/feature/add-conway-gov-to-common-constraints
branch
from
dddeb59 to
bf60069
Compare
carbolymer
force-pushed
the
mgalazyn/feature/add-conway-gov-to-common-constraints
branch
from
bf60069 to
d0cfc2b
Compare
9 tasks
palas
approved these changes
Apr 24, 2026
Contributor
palas
left a comment
palas
left a comment
There was a problem hiding this comment.
If it compiles, adding constraints to EraCommonContraints is definitely beneficial 👍
Jimbo4350
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Add Conway governance constraints to experimental constraints
Checklist
.changes/