Skip to content

UTxO-HD targeting main#719

Closed
jasagredo wants to merge 1 commit into
masterfrom
utxo-hd-main
Closed

UTxO-HD targeting main#719
jasagredo wants to merge 1 commit into
masterfrom
utxo-hd-main

Conversation

@jasagredo
Copy link
Copy Markdown
Contributor

@jasagredo jasagredo commented Jan 9, 2025

Changelog

- description: |
    Implement the changes required for UTxO-HD. See the documentation https://ouroboros-consensus.cardano.intersectmbo.org/docs/for-developers/utxo-hd/Overview.
    - Augment `Cardano.Api.LedgerState.LedgerState` with Cardano `LedgerTables`.
    - Require `SingI` for `QueryFootprint`s in Consensus queries
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Integrates the UTxO-HD changes in cardano-api. See the documentation for an extensive discussion on what the changes are and their implications.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Comment thread cardano-api/internal/Cardano/Api/LedgerState.hs
Comment on lines +83 to +95
- name: Linux install lmdb
if: matrix.sys.os == 'ubuntu-latest'
run: sudo apt install liblmdb-dev

- name: Mac install lmdb
if: matrix.sys.os == 'macos-latest'
run: brew install lmdb

- name: Windows install lmdb
if: matrix.sys.os == 'windows-latest'
shell: 'C:/msys64/usr/bin/bash.exe -e {0}'
run: /usr/bin/pacman --noconfirm -S mingw-w64-x86_64-lmdb

Copy link
Copy Markdown
Contributor

@carbolymer carbolymer Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should go into input-output-hk/actions/base to avoid having extra steps in multiple repos.

@jasagredo jasagredo force-pushed the utxo-hd-main branch 2 times, most recently from 1adad96 to 3b4a3fd Compare January 28, 2025 14:27
@jasagredo jasagredo force-pushed the utxo-hd-main branch 2 times, most recently from 36ba143 to 25192aa Compare February 10, 2025 14:36
@jasagredo
Copy link
Copy Markdown
Contributor Author

Subsumed by #774

@jasagredo jasagredo closed this Apr 10, 2025
@jasagredo jasagredo deleted the utxo-hd-main branch April 28, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants