Skip to content

Conversation

@sgillespie
Copy link
Contributor

Description

Add back the following linker options:

  • -lpgcommon
  • -lpgport

These got removed at some point to test if they were still needed (they are), but for some reason never got added back.

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

@sgillespie sgillespie marked this pull request as ready for review October 27, 2025 19:59
@sgillespie sgillespie requested a review from a team October 27, 2025 19:59
Add back the following linker options:

 * -lpgcommon
 * -lpgport

These got removed at some point to test if they were still needed (they
are), but for some reason never got added back.

Resolves: IntersectMBO#2009
@sgillespie sgillespie merged commit 4132323 into IntersectMBO:master Nov 4, 2025
12 checks passed
@sgillespie sgillespie deleted the fix/pg-static-build branch November 4, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants