CI: add shellcheck and actionlint#5804
Merged
Merged
Conversation
smelc
force-pushed
the
smelc/add-shellcheck-and-actionlint-to-ci
branch
from
9326b56 to
a932e55
Compare
smelc
force-pushed
the
smelc/add-shellcheck-and-actionlint-to-ci
branch
3 times, most recently
from
0c52974 to
68b800e
Compare
carbolymer
approved these changes
May 15, 2024
carbolymer
left a comment
carbolymer
left a comment
Contributor
There was a problem hiding this comment.
Nice work! Are we planning to remove *-exceptions.txt files at some point in the future?
| ghcid | ||
| haskell-language-server | ||
| cabal | ||
| shellcheck |
Contributor
There was a problem hiding this comment.
Seems that actionlint is a available in nixpkgs, so maybe it would be better to add it here instead of manual download step in a workflow?
Contributor
Author
There was a problem hiding this comment.
Hum yeah I had missed that actionlint is in nixpkgs 🤦
I added it to the dev shell and removed the custom installation from the workflow 👍
Jimbo4350
approved these changes
May 15, 2024
smelc
force-pushed
the
smelc/add-shellcheck-and-actionlint-to-ci
branch
from
68b800e to
8f7682b
Compare
smelc
force-pushed
the
smelc/add-shellcheck-and-actionlint-to-ci
branch
from
8f7682b to
637c9dd
Compare
Contributor
Author
@carbolymer> this is not for me to take this decision but it's a desirable goal in the long run 🙂 cc @angerman (if you happen to be the one that can nudge this forward!?) |
2 tasks
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR brings pipelines that were first added to CLI (IntersectMBO/cardano-cli#734 and IntersectMBO/cardano-cli#740) to the node. This is also a follow-up of IntersectMBO/cardano-cli#734 (review).
This PR intentionally does not try to make more scripts pass
shellchecknor try to have more pipelines files passactionlint(except for bumping a version ofupload-artifactwhich is, as stated on actions/upload-artifact#actionsupload-artifact, going to be deleted in June). This can be done in future PRs. The point of this PR is to capture the current state (i.e. a number of shell scripts and pipelines are already being checked) and also to increase the quality of future additions, because the new pipelines will automatically run on newly added shell scripts and pipelines files (since they won't be in the*-exceptions.txtfiles).How to trust this PR
shellcheckandactionlintyourselfChecklist