refactor(pay): make autoMinUtxo opt-in via BuildOptions#320
Merged
Conversation
Add autoMinUtxo flag to TxBuilderConfig (builder-level default) and PayToAddressParams (per-call override). Default is off, preserving existing behavior. When enabled, outputs below the protocol minimum are bumped up automatically. Revert UnfrackChangeHandling test values to pre-bump defaults.
autoMinUtxo is a per-build concern, not a per-builder one. Move it to BuildOptions so it is passed to .build() alongside other build-time settings like protocolParameters and coinSelection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#311 merged auto min-UTxO enforcement that always silently bumps
payToAddressoutputs. This is dangerous for script-address outputs where validators check exact values, breaks budget determinism for batch payouts, and prevents testing error paths.Make
autoMinUtxoopt-in: add it toBuildOptions(off by default) with a per-call override onPayToAddressParams. Revert theUnfrackChangeHandlingtest changes since default-off restores pre-#311 behavior.