fix(ci): switch GITHUB_OUTPUT to GITHUB_ENV and isolate npm install#355
Merged
Conversation
Two bugs fixed in post-release-to-x workflow: 1. Mode B: Replace steps.releases.outputs.found (GITHUB_OUTPUT) with env.HAS_RELEASES (GITHUB_ENV). The output-based approach was silently corrupting the value inside the multi-line run block, causing all downstream if: conditions to skip. 2. Mode C: Run npm install twitter-api-v2 in an isolated temp dir instead of the monorepo root to avoid peer dependency conflicts (e.g. @effect/docgen requiring typescript@^5.2.2 vs project using typescript@^6.0.3).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs fixed in the post-release-to-x workflow:
Fix 1 — Steps skipping despite found=true (Mode B)
echo "found=$FOUND" >> $GITHUB_OUTPUTinside a multi-linerun: |block was silently corrupting the value, causingif: steps.releases.outputs.found == 'true'to evaluate false every time. Switched toGITHUB_ENV(env.HAS_RELEASES) which writes to a clean file and avoids stdout-parsing edge cases.Fix 2 — npm install peer dep conflict (Mode C)
npm install twitter-api-v2@1in the monorepo root triggered full dependency resolution, hitting the@effect/docgen→typescript@^5.2.2vstypescript@^6.0.3mismatch. Now installs in an isolated temp dir (/tmp/tweet-lib/) with its own emptypackage.json.Test plan:
@evolution-sdk/tagworkflow_dispatchwithin 1 hourcompleted | successinstead ofskipped