Skip to content

Backend epoch boundary test #2185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kneerose merged 2 commits into from
Oct 22, 2024
Merged

Backend epoch boundary test #2185

kneerose merged 2 commits into from
Oct 22, 2024

Conversation

@kneerose
Copy link
Contributor

@kneerose kneerose commented Oct 21, 2024

List of changes

  • Add kuber service to get genesis-param
  • Add epoch boundary test to validate expiry epoch and date

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose requested a review from mesudip October 21, 2024 04:03
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024

✅ All checks succeeded

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024

✅ All checks succeeded

mesudip
mesudip approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@kneerose kneerose merged commit d6398d2 into develop Oct 22, 2024
@kneerose kneerose deleted the backend-test/epoch-boundary branch October 22, 2024 05:36
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024

@kneerose
This PR is in the tag: develop-d6398d29590de75aa1b69bd89ce6d091dc5f0be7 , for govtool-frontend service

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024

@kneerose
This PR is in the tag: develop-d6398d29590de75aa1b69bd89ce6d091dc5f0be7 , for govtool-metadata-validation service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mesudip mesudip mesudip approved these changes

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

@MSzalowski MSzalowski Awaiting requested review from MSzalowski

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kneerose @mesudip