Skip to content

Utilize the network for possible URL cases and remove unnecessary environment variables #2463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kneerose merged 1 commit into from
Dec 4, 2024
Merged

Utilize the network for possible URL cases and remove unnecessary environment variables #2463

kneerose merged 1 commit into from
Dec 4, 2024

Conversation

@kneerose
Copy link
Contributor

@kneerose kneerose commented Dec 4, 2024 •
edited
Loading

List of changes

  • Remove unwanted env and get faucet and blockfrost api keys based on network

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose requested a review from mesudip December 4, 2024 08:40
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ All checks succeeded

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ All checks succeeded

mesudip
mesudip approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kneerose kneerose merged commit 460b5ca into develop Dec 4, 2024
4 checks passed
@kneerose kneerose deleted the refactor/test-env branch December 4, 2024 09:02
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

@kneerose
This PR is in the tag: develop-460b5ca38fbf4973e882691dc408ba4b928d6feb , for govtool-metadata-validation service

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

@kneerose
This PR is in the tag: develop-460b5ca38fbf4973e882691dc408ba4b928d6feb , for govtool-frontend service

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

@kneerose
This PR is in the tag: develop-460b5ca38fbf4973e882691dc408ba4b928d6feb , for govtool-backend service

@kneerose kneerose changed the title Remove unwanted env and get faucet and blockfrost api keys based on network Utilize the network for possible URL cases and remove unnecessary environment variables Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mesudip mesudip mesudip approved these changes

@adgud adgud Awaiting requested review from adgud

@MSzalowski MSzalowski Awaiting requested review from MSzalowski

@jdyczka jdyczka Awaiting requested review from jdyczka

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

+1 more reviewer

@placek placek placek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kneerose @placek @mesudip