Tests: script based dRep conversion #3224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
✅ All checks succeeded |
2 similar comments
Contributor
|
✅ All checks succeeded |
Contributor
|
✅ All checks succeeded |
mesudip
reviewed
Mar 18, 2025
| "elements": [ | ||
| { | ||
| "isScriptBased": true, | ||
| "drepId": "429b12461640cefd3a4a192f7c531d8f6c6d33610b727f481eb22d39", |
Contributor
There was a problem hiding this comment.
Do we have similar test for keyDrep? If not let's add it too.
Contributor
Author
There was a problem hiding this comment.
You can review this update -https://github.com/IntersectMBO/govtool/pull/3224/files#:~:text=.isScriptBased)-,const%20cip129DRepListApi%20%3D%20dRepList.map(,)%3B,-for%20(let. This is the only test where the conversion of a dRep takes place, whether it's script-based or a normal dRep.
Contributor
|
✅ All checks succeeded |
2 similar comments
Contributor
|
✅ All checks succeeded |
Contributor
|
✅ All checks succeeded |
Contributor
|
✅ All checks succeeded |
2 similar comments
Contributor
|
✅ All checks succeeded |
Contributor
|
✅ All checks succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
convertDRepTo129helper function to convertconvertDRep, supporting both CIP-129 and CIP-105 usingdRepView.Checklist