Skip to content

fix drep vote calculation for proposal display tests #4057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kneerose merged 1 commit into from
Sep 5, 2025
Merged

fix drep vote calculation for proposal display tests #4057

kneerose merged 1 commit into from
Sep 5, 2025

Conversation

@JosephRana11
Copy link
Contributor

@JosephRana11 JosephRana11 commented Sep 5, 2025

List of changes

  • Fixed DRep's Vote calculation logic in Outcome details Page.

Test Cases now Fixed from this change

  • 9G_1. Should display correct vote counts on outcome details page in disconnect state
  • 9G_2. Should display correct vote counts on outcome details page

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose self-requested a review September 5, 2025 08:39
kneerose
kneerose approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@kneerose kneerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@kneerose kneerose merged commit 5ac3838 into IntersectMBO:develop Sep 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

@JosephRana11
This PR is in the tag: develop-5ac3838adb4ab41863b17f4b4471009a32b3ec21 , for govtool-metadata-validation service

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

@JosephRana11
This PR is in the tag: develop-5ac3838adb4ab41863b17f4b4471009a32b3ec21 , for govtool-backend service

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

@JosephRana11
This PR is in the tag: develop-5ac3838adb4ab41863b17f4b4471009a32b3ec21 , for govtool-frontend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kneerose kneerose kneerose approved these changes

@MSzalowski MSzalowski Awaiting requested review from MSzalowski

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JosephRana11 @kneerose