Skip to content

Added contributing guide, early 9.4 support#20

Merged
coot merged 4 commits into
mainfrom
coot/maitnance
Sep 3, 2022
Merged

Added contributing guide, early 9.4 support#20
coot merged 4 commits into
mainfrom
coot/maitnance

Conversation

@coot
Copy link
Copy Markdown
Collaborator

@coot coot commented Sep 2, 2022

  • Added LICENSE and NOTICE files
  • Added CONTRIBUTING.md document
  • Early support for GHC 9.4.2
  • Use GHC 9.2.4 in CI

@coot coot requested a review from bolt12 September 2, 2022 08:04
@coot coot self-assigned this Sep 2, 2022
bolt12
bolt12 suggested changes Sep 2, 2022
View reviewed changes
Comment thread CONTRIBUTING.md Outdated
# Contributing to io-sim

We designed `io-classes` to be as close as possible to what `base` package
provides. Almost all `IO` instances intstantiate with api provided by one of
Copy link
Copy Markdown
Contributor

@bolt12 bolt12 Sep 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not entirely sure what you mean with the second sentence.

Copy link
Copy Markdown
Collaborator Author

@coot coot Sep 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to convey they sprit of such insetances as this one.

Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread io-sim/src/Control/Monad/IOSim/Internal.hs
Comment thread io-sim/src/Control/Monad/IOSim/Internal.hs
Comment thread io-sim/src/Control/Monad/IOSimPOR/Internal.hs
Comment thread io-classes/src/Control/Monad/Class/MonadMVar.hs
coot added 2 commits September 2, 2022 12:12
@coot
Added CONTRIBUTING.md document
7dd2073
@coot
Early support for GHC 9.4.2
4f6c205 
We still need:
* cborg
* serialise
which support 9.4.2.  Both are addressed in
well-typed/cborg#298
@coot
Copy link
Copy Markdown
Collaborator Author

coot commented Sep 2, 2022

These are the settings one needs to add to cabal.project.local file right now to build it with ghc-9.4.

allow-newer: typed-protocols-cborg:base
           , typed-protocols-examples:base
           , cborg:base
           , cborg:ghc-prim
           , cborg:primitive
           , serialise:ghc-prim
           , serialise:time
           , serialise:text
           , serialise:bytestring

@coot coot merged commit 2dee590 into main Sep 3, 2022
@coot coot deleted the coot/maitnance branch September 3, 2022 07:37
@L-as L-as mentioned this pull request Sep 13, 2022
Closed
@coot coot mentioned this pull request Oct 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bolt12 bolt12 bolt12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@coot coot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@coot @bolt12