Enable ordinary-index building without a page count bound #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeltsch
requested review from
dcoutts,
jorisdral,
mheinzel and
recursion-ninja
as code owners
jeltsch
force-pushed
the
jeltsch/growing-vector
branch
from
6bc89d6 to
1db7791
Compare
jeltsch
force-pushed
the
jeltsch/growing-vector
branch
from
1db7791 to
db4f2f9
Compare
jorisdral
requested changes
Oct 7, 2024
Collaborator
jorisdral
left a comment
jorisdral
left a comment
There was a problem hiding this comment.
Looks great, just a few small suggestions
jeltsch
force-pushed
the
jeltsch/growing-vector
branch
from
ba9ce06 to
65fed76
Compare
jorisdral
approved these changes
Oct 24, 2024
Collaborator
|
Let's squash the commits, and then we can merge |
jeltsch
force-pushed
the
jeltsch/growing-vector
branch
from
4492f4a to
b7fb557
Compare
jeltsch
force-pushed
the
jeltsch/growing-vector
branch
from
b7fb557 to
cce6276
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, incremental construction of an ordinary index required users to provide an upper bound of the number of pages or equivalently the number of keys stored in the index. However, such an upper bound cannot be reliably computed.
This pull request introduces an implementation of “growing vectors” and adapts ordinary-index construction to make use of it. As a result, it is not necessary anymore to provide an upper bound of the number of keys but only an initial size of the key buffer. For performance reasons, it is good for this initial size to be an upper bound of the number of keys, but index construction will also work if it is not.
This pull request does not contain tests for growing vectors. These will be added later by resolving #420.