Implement a more proper snapshot format #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current snapshot format is only loosely established, so we add a more concrete snapshot format, which is more amenable to refactoring. This snapshot format is still temporary -- we will implement snapshots properly in a later package.
jorisdral
requested review from
dcoutts,
mheinzel and
recursion-ninja
as code owners
dcoutts
approved these changes
Oct 14, 2024
Collaborator
dcoutts
left a comment
dcoutts
left a comment
There was a problem hiding this comment.
So unless I missed anything, this is mostly just moving the interim impl of snapshots from .Internal (and .Config and .RunNumber) into .Snapshot. Which is fine.
Collaborator
Author
That, and the (interim) format of a snapshot is more explicit |
mheinzel
approved these changes
Oct 14, 2024
Collaborator
mheinzel
left a comment
mheinzel
left a comment
There was a problem hiding this comment.
That looks like a sensible improvement 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current snapshot format is only loosely established, so we add a more concrete snapshot format, which is more amenable to refactoring. This snapshot format is still temporary -- we will implement snapshots properly in a later package.
#426 is near to being ready, but it is currently still failing some tests related to snapshots. Establishing a snapshot format makes bug-hunting in the snapshot code easier.