move Cursor read logic into separate module #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheinzel
requested review from
dcoutts,
jorisdral and
recursion-ninja
as code owners
Closed
jorisdral
approved these changes
Oct 21, 2024
src/Database/LSMTree/Internal.hs
Outdated
Comment on lines
3
to
13
| -- | The internal API here is defined in terms of untyped serialised keys, | ||
| -- values and blobs. It makes no distinction between normal and monoidal tables, | ||
| -- accepting both blobs and mupserts. | ||
| -- | ||
| -- This module mainly deals with concurrency- and exception-safe opening and | ||
| -- closing of resources. Any other non-trivial logic should live somewhere else. | ||
| -- |
Collaborator
There was a problem hiding this comment.
Nice, it is indeed helpful if we record the intention of the module here. Maybe we should also note here that this module is, in a way, bringing all internal parts together to implement the public API.
mheinzel
force-pushed
the
mheinzel/module-cursor
branch
from
a5fe228 to
4f48704
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of splitting the whole module as proposed in #432, we might want to just move more logic out of the
Internalmodule (without API types likeCursorandTableHandle). I also documented that approach in the module description.