Cleanups related to write buffer updates and value resolution in the core library. #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `addEntries`, `addEntryMonoidal` and `addEntryNormal`. `addEntries` is only used in tests, and can be replaced by `sconcat`. `addEntryMonoidal` and `addEntryNormal` were only used in the `WriteBuffer` micro-benchmark, but that code is now refactored to use `addEntry` instead.
That is, inline the injection/projections from the `D.L.I.Entry` module at their use sites.
These functions are only used in tests. Moreover, the tests can replace these functions by 'Semigroup' functions like 'sconcat'.
Since none of the internal code still relies on these type definitions, remove the `D.L.I.Normal` and `D.L.I.Monoidal` modules, and move the types to the `D.L.Normal` and `D.L.Monoidal` modules.
jorisdral
requested review from
dcoutts,
mheinzel and
recursion-ninja
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had realised some of this core library code was unused, in which case I removed the code. In other cases, where the code was only used in tests/benchmarks, I inlined the definitions and did some refactoring.