Simplify pre-commit scripts. #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenkokke
requested review from
dcoutts,
jorisdral,
mheinzel and
recursion-ninja
as code owners
jorisdral
approved these changes
Oct 25, 2024
Collaborator
jorisdral
left a comment
jorisdral
left a comment
There was a problem hiding this comment.
LGTM! And it's also nice that it now prints the files that are checked/formatted
Collaborator
|
FYI, to make CI pass these lines have to be modified to call the renamed formatting scripts: lsm-tree/.github/workflows/haskell.yml Line 274 in c361efb lsm-tree/.github/workflows/haskell.yml Line 212 in c361efb |
wenkokke
force-pushed
the
wenkokke/simplify-scripts
branch
from
262b27b to
b121090
Compare
Collaborator
Author
|
I've back ported some added robustness from a different project that checks for unstaged files and checks for the formatter versions. |
jorisdral
approved these changes
Oct 28, 2024
Collaborator
jorisdral
left a comment
jorisdral
left a comment
There was a problem hiding this comment.
LGTM again. Let's squash the commits a bit before we merge
wenkokke
force-pushed
the
wenkokke/simplify-scripts
branch
4 times, most recently
from
d86c2e9 to
aac59d2
Compare
Collaborator
|
Seems like something went wrong when rebasing, GitHub thinks you're adding 39 new commits. |
jorisdral
force-pushed
the
wenkokke/simplify-scripts
branch
from
aac59d2 to
fecc54d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caveats may apply.
Notably, this removes support for the path/command flags and requires that the scripts are run from the repository root.
I'm happy to restore support for the path/command flags and permit the commands to work from any directory, but figured I shouldn't complicate these files if that was unused complexity.