Rename table merge to table union in the public API #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
requested review from
dcoutts,
mheinzel and
recursion-ninja
as code owners
jorisdral
force-pushed
the
jdral/rename-table-union
branch
3 times, most recently
from
789687a to
3d6b8c3
Compare
mheinzel
reviewed
Nov 6, 2024
Collaborator
mheinzel
left a comment
mheinzel
left a comment
There was a problem hiding this comment.
The renaming makes sense, but the explanation of the semantics is off.
mheinzel
approved these changes
Nov 6, 2024
"Table union" seems to be more appropriate than "table merge", since "merge" is often used in the LSM-Tree literature to mean "run merges". The table union semantics are also similar to `Map.union` from the well known `Data.Map` module, so just from the name it should be more obvious at a glance what the semantics of "table union" are. The semantics of table union are made a little more specific in the haddocks.
jorisdral
force-pushed
the
jdral/rename-table-union
branch
from
07787b0 to
6876398
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Table union" seems to be more appropriate than "table merge", since "merge" is often used in the LSM-Tree literature to mean "run merges". The table union semantics are also similar to
Map.unionfrom the well knownData.Mapmodule, so just from the name it should be more obvious at a glance what the semantics of "table union" are.The semantics of table union are made a little more specific in the haddocks.