Create a proper directory for each snapshot #456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
requested review from
dcoutts,
mheinzel and
recursion-ninja
as code owners
jorisdral
force-pushed
the
jdral/named-snapshot-directory
branch
2 times, most recently
from
79d3aa5 to
bc200ff
Compare
jorisdral
changed the title
jorisdral
force-pushed
the
jdral/named-snapshot-directory
branch
from
bc200ff to
64107a8
Compare
Collaborator
|
LGTM |
wenkokke
reviewed
Nov 8, 2024
wenkokke
reviewed
Nov 8, 2024
And put the snapshot metadata file in there. In addition, compute the checksum for the metadata file and put it in a separate file in the same directory.
jorisdral
force-pushed
the
jdral/named-snapshot-directory
branch
from
64107a8 to
41377ab
Compare
wenkokke
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And put the snapshot metadata file in there. In addition, compute the checksum for the metadata file and put it in a separate file in the same directory.