Tweak API #458
Merged
Tweak API #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheinzel
requested review from
dcoutts,
jorisdral and
recursion-ninja
as code owners
mheinzel
force-pushed
the
mheinzel/tweak-api
branch
from
c46ce30 to
508fee6
Compare
jorisdral
approved these changes
Nov 11, 2024
| -> SnapshotName | ||
| -> (h m k v -> m a) | ||
| -> m a | ||
| withTableOpen sesh snap = bracket (open sesh snap) close |
Collaborator
There was a problem hiding this comment.
We could also rename this bit to withTableOpenSnapshot or some similar name
Collaborator
Author
There was a problem hiding this comment.
I called it withTableFromSnapshot
The "main" argument (keys, values, ...) comes last, allowing to pass a large expression there (e.g. long explicit list).
mheinzel
force-pushed
the
mheinzel/tweak-api
branch
from
508fee6 to
6dc6d8d
Compare
mheinzel
force-pushed
the
mheinzel/tweak-api
branch
from
6dc6d8d to
7903d6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to make it a bit clearer and more convenient to use.