Make the different index types use a common chunk type #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeltsch
requested review from
dcoutts,
jorisdral and
mheinzel
as code owners
jeltsch
force-pushed
the
jeltsch/common-chunk-type
branch
2 times, most recently
from
d94ce03 to
bf65190
Compare
jorisdral
approved these changes
Nov 11, 2024
jeltsch
force-pushed
the
jeltsch/common-chunk-type
branch
from
9b1599e to
aa81901
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the compact index use the
Chunktype defined inDatabase.LSMTree.Internal.Chunk, which the ordinary index is already using. This paves the way to a common interface for both the ordinary and the compact index.