Proper snapshot implementation #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
commented
Nov 13, 2024
jorisdral
requested review from
dcoutts,
mheinzel,
recursion-ninja and
wenkokke
as code owners
mheinzel
requested changes
Nov 18, 2024
Collaborator
mheinzel
left a comment
mheinzel
left a comment
There was a problem hiding this comment.
Looks good! Just maybe take another look at exception-safety before merging (as you pointed out yourself).
jorisdral
force-pushed
the
jdral/proper-snapshot-impl
branch
from
16b4beb to
ffd6e60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #457. The aim of this PR is to switch to properly implementing snapshots using hard links, although we're using a placeholder
hardLinkfunction for now. The PR can best be read patch by patch.