Move ChecksumHandle to CRC32C #470
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenkokke
requested review from
dcoutts,
jorisdral,
mheinzel and
recursion-ninja
as code owners
jorisdral
approved these changes
Nov 14, 2024
| import GHC.Exts | ||
| import qualified GHC.ForeignPtr as Foreign | ||
| import System.FS.API | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
and run stylish-haskell
Comment on lines
370
to
371
| {-| $checksum-handles | ||
| A handle ('ChecksumHandle') that maintains a running CRC32 checksum. | ||
| -} |
Collaborator
There was a problem hiding this comment.
I think you can leave out the |
| writeBlob builder blob | ||
| --TODO: can't easily switch this to use BlobFile.writeBlob because | ||
| -- RunBuilder currently does everything uniformly with ChecksumHandle. | ||
| -- RunBuilder currently does everything uniformly with CRC. |
Collaborator
There was a problem hiding this comment.
Probably accidental
Suggested change
| -- RunBuilder currently does everything uniformly with CRC. | |
| -- RunBuilder currently does everything uniformly with ChecksumHandle. |
wenkokke
force-pushed
the
wenkokke/move-checksumhandle
branch
from
e9c5a40 to
e6bec5c
Compare
Collaborator
Author
|
Closing in favour of #472. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
ChecksumHandletype toCRC32Cto enable reuse (without exporting it fromRunBuilder).