Skip to content

Conversation

@jorisdral
Copy link
Collaborator

Require the user to pass in snapshot labels explicitly. The responsibility of managing label falls on the user, just like the user has the reponsibility of managing snapshot names.

@jorisdral
Copy link
Collaborator Author

jorisdral commented Nov 28, 2024

@wenkokke thanks for the review! I probably won't merge the PR yet until #417 has landed on main

@jorisdral jorisdral added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@jorisdral jorisdral force-pushed the jdral/revisit-snapshot-label branch from 87ec3c9 to 3430da6 Compare December 2, 2024 09:53
@jorisdral jorisdral enabled auto-merge December 2, 2024 09:53
Require the user to pass in snapshot labels explicitly. The responsibility of
managing label falls on the user, just like the user has the reponsibility of
managing snapshot names.
@jorisdral jorisdral force-pushed the jdral/revisit-snapshot-label branch from 3430da6 to a2a03c6 Compare December 2, 2024 10:01
@jorisdral jorisdral added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit 6904297 Dec 2, 2024
27 checks passed
@jorisdral jorisdral deleted the jdral/revisit-snapshot-label branch December 2, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants