Add mupserts and table unions to the state machine tests #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
requested review from
dcoutts,
mheinzel,
recursion-ninja and
wenkokke
as code owners
jorisdral
force-pushed
the
jdral/single-api-qls
branch
from
0bfbac3 to
d51871a
Compare
jorisdral
force-pushed
the
jdral/single-api
branch
3 times, most recently
from
1a8d287 to
986bec6
Compare
jorisdral
force-pushed
the
jdral/single-api-qls
branch
from
d51871a to
5f61aee
Compare
jorisdral
force-pushed
the
jdral/single-api
branch
2 times, most recently
from
7bedfcc to
36b4a77
Compare
jorisdral
force-pushed
the
jdral/single-api
branch
2 times, most recently
from
ea4dd27 to
669e7f5
Compare
Collaborator
Author
|
#469 was merged, so I'll update this PR before undrafting it |
jorisdral
force-pushed
the
jdral/single-api-qls
branch
from
5f61aee to
d98f5ad
Compare
jorisdral
commented
Nov 27, 2024
mheinzel
reviewed
Nov 27, 2024
mheinzel
approved these changes
Nov 27, 2024
jorisdral
force-pushed
the
jdral/single-api-qls
branch
from
d98f5ad to
6058205
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #469. This PR is put in draft mode until we've come to a conclusion about the proposal in #469.
In this PR, we first create a class and reference implementation for the "full" API that is introduced in #469. Then, we switch the state machine tests to use this class instead of the
Normalclass. Finally, we can add infrastructure for both mupserts and table unions to the state machine tests. We start testing mupserts immediately, but table union operations are not yet generated because table union does not have an implementation yet.