Move MergePolicyForLevel from MergingRun to IncomingRun #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the changes to the scheduled merges prototype to introduce table unions, this refactoring was done. This is because the merging run gets reused in tree merges, where the merging policy makes no sense. So we move it up one level into something that's specific to the levels (the incomming run). So this is the corresonding refactoring as in the prototype, and is preparation for introducing table unions.
dcoutts
requested review from
jorisdral,
mheinzel,
recursion-ninja and
wenkokke
as code owners
mheinzel
approved these changes
Dec 19, 2024
dcoutts
deleted the
dcoutts/move-mergepolicy-from-mergingrun-to-incomingrun
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the changes to the scheduled merges prototype to introduce table unions, this refactoring was done. This is because the merging run gets reused in tree merges, where the merging policy makes no sense. So we move it up one level into something that's specific to the levels (the incomming run).
So this is the corresponding refactoring as in the prototype, and is preparation for introducing table unions.