Resolving TODO: Converted FilePointer to Word representation #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recursion-ninja
requested review from
dcoutts,
jorisdral,
mheinzel and
wenkokke
as code owners
recursion-ninja
force-pushed
the
recursion-ninja/FilePointer-conversion
branch
2 times, most recently
from
75bbbc9 to
d416bcd
Compare
jorisdral
reviewed
Dec 23, 2024
dcoutts
previously requested changes
Jan 7, 2025
Collaborator
dcoutts
left a comment
dcoutts
left a comment
There was a problem hiding this comment.
I don't think it's worth making this change. It does not fix the theoretical problem (of 31bit max file size for the WBB blob file on 32bit systems), which itself is hardly a practical limitation.
It doesn't solve it because it just switches from Int to Word, which is the same size. It'd need Word64 atomic support on 32bit systems (which ghc does not support, and which may not be available on all 32bit arches that ghc does support).
So I propose we just close this.
Collaborator
|
I repurposed this PR to replace the TODO with a general comment about word size limits |
jorisdral
force-pushed
the
recursion-ninja/FilePointer-conversion
branch
from
d416bcd to
5494b66
Compare
Co-authored-by: Recursion Ninja <github@recursion.ninja>
jorisdral
force-pushed
the
recursion-ninja/FilePointer-conversion
branch
from
5494b66 to
f0e00a8
Compare
jorisdral
approved these changes
Jan 9, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A small refactoring addressing the TODO task of converting the
FilePointerrepresentation toWord, while exposing aWord64API.The implementation in the PR replicates the definition of
Data.Primitive.PrimVar.fetchAddInt, adapted for the unsignedWordtype.