Use ActionRegistry instead of TempRegistry everywhere
#510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
requested review from
dcoutts,
mheinzel,
recursion-ninja and
wenkokke
as code owners
jorisdral
changed the title
ActionRegistry instead of TempRegistry everywhereActionRegistry instead of TempRegistry everywhere
jorisdral
force-pushed
the
jdral/replace-registry
branch
from
0f2cb16 to
6e6f726
Compare
jorisdral
force-pushed
the
jdral/replace-registry
branch
from
6e6f726 to
d8ac09e
Compare
jorisdral
force-pushed
the
jdral/replace-registry
branch
from
d8ac09e to
526beec
Compare
dcoutts
approved these changes
Jan 7, 2025
Collaborator
dcoutts
left a comment
dcoutts
left a comment
There was a problem hiding this comment.
One minor comment below. Otherwise, ready to merge.
Say we have two delayed actions we want to register in the following order: close a file handle, and remove the corresponding file. When the action registry is committed, then previously we would run the actions in LIFO order. This leads to an error because we can't remove a file while we also have an open handle to that file. Now that we run the actions in FIFO order, it works correctly.
jorisdral
force-pushed
the
jdral/replace-registry
branch
from
526beec to
2c7a183
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.