Skip to content

First semigroup instead of First monoid for blob semantics #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jorisdral merged 2 commits into from
Jan 29, 2025
Merged

First semigroup instead of First monoid for blob semantics #548

jorisdral merged 2 commits into from
Jan 29, 2025

Conversation

@jorisdral
Copy link
Collaborator

@jorisdral jorisdral commented Jan 24, 2025

No description provided.

@jorisdral jorisdral self-assigned this Jan 24, 2025
mheinzel
mheinzel reviewed Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@mheinzel mheinzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there is probably some documentation that should also get updated.

@jorisdral
Copy link
Collaborator Author

jorisdral commented Jan 29, 2025

Looks good, but there is probably some documentation that should also get updated.

I've taken some of your suggestions from 6790d82. If there are other places where documenattion has to be updated, could you point me to them?

@mheinzel
Copy link
Collaborator

mheinzel commented Jan 29, 2025

If there are other places where documenattion has to be updated, could you point me to them?

I briefly looked for other places, but it seems like we have never really been precise about what monoidal behaviour to expect from blobs, mainly because these cases aren't possible via the Normal/Monoidal API. Maybe a short sentence could be added to the docs of combine and combineUnion to clarify that blobs are taken from the left/new value only, but that's all I think.

@jorisdral jorisdral enabled auto-merge January 29, 2025 11:55
@jorisdral jorisdral added this pull request to the merge queue Jan 29, 2025
auto-merge was automatically disabled January 29, 2025 16:48

Pull Request is not mergeable

Merged via the queue into main with commit c202034 Jan 29, 2025
27 checks passed
@jorisdral jorisdral deleted the jdral/normal-union branch January 29, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mheinzel mheinzel mheinzel approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts is a code owner

@recursion-ninja recursion-ninja Awaiting requested review from recursion-ninja recursion-ninja is a code owner

@wenkokke wenkokke Awaiting requested review from wenkokke wenkokke is a code owner

Assignees

@jorisdral jorisdral

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jorisdral @mheinzel