Public API: add union debt/credits types and related functions #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
requested review from
dcoutts,
mheinzel,
recursion-ninja and
wenkokke
as code owners
mheinzel
reviewed
Mar 5, 2025
Collaborator
mheinzel
left a comment
mheinzel
left a comment
There was a problem hiding this comment.
We currently put (largely identical) documentation on the identifiers in Normal and Monoidal, don't have documentation in the top level LSMTree module (since we are not sure about its future) and in Internal we only link to the public API. I don't see any better approach at the moment, so I think we should stick to it.
If Monoidal also simply linked to Normal, we'd avoid any duplication. But that's not a great experience for someone looking at the Monoidal Haddocks.
mheinzel
reviewed
Mar 5, 2025
jorisdral
force-pushed
the
jdral/union-credit-debt
branch
from
c5ec99f to
dec8a7c
Compare
jorisdral
force-pushed
the
jdral/union-credit-debt
branch
from
dec8a7c to
636f233
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is left open for now. I'll follow up this PR with a PR to add test support for union debt/supply.