Add assertions about keys to ordinary-index construction #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeltsch
requested review from
dcoutts,
jorisdral,
mheinzel,
recursion-ninja and
wenkokke
as code owners
jorisdral
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds assertions that guarantee that minimum keys used in the construction of ordinary indexes fulfill necessary conditions.
This addition is important because we plan to change the tests of higher-level modules to use ordinary indexes instead of compact ones. After this change, these tests wouldn’t catch passing of bogus minimum keys anymore without the extra assertions of this pull request, since minimum keys are ignored when building ordinary indexes.