Faster shrinker test for Compat's Chunks generator #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoutts
requested review from
jorisdral,
mheinzel,
recursion-ninja and
wenkokke
as code owners
Use prop_arbitraryAndShrinkPreserveInvariant rather than the naive version (which no doubt pre-dates the handy util). On my machine with an unoptimised build, improves running time from 50s to 17s.
dcoutts
force-pushed
the
dcoutts/quicker-test-shrink-compact-Chunks
branch
from
18768ca to
42a1dbc
Compare
jorisdral
approved these changes
Mar 14, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use prop_arbitraryAndShrinkPreserveInvariant rather than the naive version (which no doubt pre-dates the handy util).
On my machine with an unoptimised build, improves running time from 50s to 17s.