-
Notifications
You must be signed in to change notification settings - Fork 9
Benchmark suite for table unions #694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f5e1248 to
0d8238e
Compare
dc2cc99 to
6617a65
Compare
|
The benchmarks have been reworked. No insert/delete/updates occur during the measurements; only lookups. The output plot has been re-rendered for clarity. The axes are now labeled with units and depict the aggregated lookup time of each batch. Per the suggestion of @dcoutts, a pre- and post- payoff performance picture is generated along side the performance as credits are supplied and the debt is repaid. |
b704902 to
625c1c3
Compare
fb1a253 to
f0ed570
Compare
60c6365 to
71f5fc1
Compare
jorisdral
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output looks nice, but I have some suggestions for changes. I've also pushed a few commits to the branch that remove features that I don't think the benchmark needs
8c162e3 to
092fdd1
Compare
092fdd1 to
8e42e98
Compare
Strange, that's not what I'm seeing on my machine. I pushed changes again. Maybe that will remove it. |
d0a90c2 to
2c4719c
Compare
d236827 to
798fb2e
Compare
798fb2e to
f5f2a19
Compare
So that haddock will render the module header. Apparently if a benchmark suite has no `other-modules`, then `cabal haddock --haddock-benchmark` won't bother rendering haddocks. With the main unions benchmark code now in a different module from the `Main` module, we get proper haddocks.
1e19d48 to
85af54b
Compare
The major changes include: * Measure the performance of all lookups batches together, instead of each batch separately * Use gnuplot instead of charts There are some cascading changes but the spirit of the benchmark stays the same.
85af54b to
fbda941
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've taken the liberty to apply changes, see the last commit message. I'm approving my own changes here (shame!), but it's not code in public libraries so I'm not letting it go through another review round by someone else. Comments are still welcome, but then I'll apply them in a follow-up PR
Thanks @recursion-ninja for the work


Benchmarks for table unions.
Overview
Here is a summary of the table union benchmark. Note that all function calls are made throught the
Database.LSMTree.SimpleAPI.Phase 1: Setup
The benchmark will setup an initial set of tables to be unioned together during "Phase 2." The number of tables create is user specified via the
--tableCountcommand line option with a default value of10tables.The size of each generated table is the same and is user specified via the$initial-size$ inserted entries in each table are randomly selected from the range following range:
--initial-sizecommand line option with a default value of1_000_000entries. Each created table has$initial-sizeinsertions operations performed on it before being written out to disk as a snapshot. TheAdditionally, the directory in which to isolate the benchmark environment is specified via the
--bench-dircommand line option, with a default of_union_wp16. The table snapshots are saved here along with the benchmarked measurements from Phase 2.Phase 2: Measurement
When generating measurements for the table unions, the benchmark will reload the snapshots of the tables generated in Phase 1 from disk. Subsequently, the tables will be "incrementally unioned" together.
Once the tables have been loaded and the union initiated, a series of "lookup batches" will be performed. A lookup batch involves performing a large number key lookups on the incrementally unioned table and then calculating the number of lookup operations per second. The measurement series consists of 200 batch lookups.
First, 50 batch lookups are performed without supplying any credits to the unioned table. This establishes a base-line performance picture. Indices [-50, 0] measure lookups to the unioned table with 100% of the debt remaining.
Subsequently, 100 more batch looukps are performed. Before each of these 100 batch lookups, a fixed number of credits are supplied to the incremental union table. The number of credits supplied remain constant between each batch lookup for the entire series of measurements. The series of measurements allows reasoning able table performance over time as the tables debt decreases (at a uniform rate). The number of credits supplied before each lookup batch is 1% of the total starting debt. After 100 steps, 100% of the debt will be paid off. Indices [1, 100] measure lookups to the unioned table with as the remaining debt decreases.
Finally, 50 concluding batch looukps are performed. Since no debt is remaining, no credits are supplied. Rather these meausrments create a "post-payoff" performance picture. Indices [101, 150] measure lookups to the unioned table with 1% of the debt remaining.
The general benchmark format is as follows:
An informative performance plot of the benchmark measurements is generated and placed in the benchmark's directory.