Skip to content

Conversation

@jorisdral
Copy link
Collaborator

No description provided.

@jorisdral
Copy link
Collaborator Author

jorisdral commented May 1, 2025

A CI run is showing a test failure:

  Test.Database.LSMTree.UnitTests
    unit_blobs:                                                                   FAIL
      [FoundWithBlob (ResolveAsFirst "value1") (WeakBlobRef {weakBlobRefFile = WeakRef (BlobFile {blobFileHandle = <Handle <root>/active/0.wbblobs>, blobFileRefCounter = <RefCounter>}), weakBlobRefSpan = BlobSpan {blobSpanOffset = 0, blobSpanSize = 5}})]
      ["\177\187t\a\SOH"]
        test/Test/Database/LSMTree/UnitTests.hs:57:
        expected: ["blob1"]
         but got: ["\177\187t\a\SOH"]
      
      Use -p '/unit_blobs/' to rerun this test only.

@jorisdral
Copy link
Collaborator Author

jorisdral commented May 6, 2025

A CI run is showing a test failure:

  Test.Database.LSMTree.UnitTests
    unit_blobs:                                                                   FAIL
      [FoundWithBlob (ResolveAsFirst "value1") (WeakBlobRef {weakBlobRefFile = WeakRef (BlobFile {blobFileHandle = <Handle <root>/active/0.wbblobs>, blobFileRefCounter = <RefCounter>}), weakBlobRefSpan = BlobSpan {blobSpanOffset = 0, blobSpanSize = 5}})]
      ["\177\187t\a\SOH"]
        test/Test/Database/LSMTree/UnitTests.hs:57:
        expected: ["blob1"]
         but got: ["\177\187t\a\SOH"]
      
      Use -p '/unit_blobs/' to rerun this test only.

I changed the unit test to a property test in 1cd7e28 that I run for 100_000 tests on each CI job (of which there are ~18), and this did not seem to exhibit the same bug. For now I'm considering to be a flaky test, because I don't have other ideas for finding a reproducer

@jorisdral jorisdral force-pushed the jdral/bump-hackage branch from 1cd7e28 to 94b7f11 Compare May 6, 2025 11:34
Copy link
Collaborator

@recursion-ninja recursion-ninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📤 LGTM

@jorisdral jorisdral enabled auto-merge May 6, 2025 11:39
@jorisdral jorisdral added this pull request to the merge queue May 6, 2025
Merged via the queue into main with commit dd977b5 May 6, 2025
28 checks passed
@jorisdral jorisdral deleted the jdral/bump-hackage branch May 6, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants