Skip to content

Make InvalidSnapshotNameError an instance of Eq #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

Make InvalidSnapshotNameError an instance of Eq #750

merged 1 commit into from
Jun 3, 2025

Conversation

@jeltsch
Copy link
Collaborator

@jeltsch jeltsch commented Jun 3, 2025 •
edited
Loading

This pull request makes InvalidSnapshotNameError and instance of Eq, because apparently all other error types are instances of Eq already.

@jeltsch jeltsch self-assigned this Jun 3, 2025
@jorisdral jorisdral added this pull request to the merge queue Jun 3, 2025
Merged via the queue into main with commit 3ba7727 Jun 3, 2025
30 checks passed
@jorisdral jorisdral deleted the jeltsch/invalid-snapshot-name-error-equality branch June 3, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorisdral jorisdral jorisdral approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts is a code owner

@mheinzel mheinzel Awaiting requested review from mheinzel mheinzel is a code owner

@recursion-ninja recursion-ninja Awaiting requested review from recursion-ninja recursion-ninja is a code owner

@wenkokke wenkokke Awaiting requested review from wenkokke wenkokke is a code owner

Assignees

@jeltsch jeltsch

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeltsch @jorisdral