Add Data-backed MintValue#6931
Merged
Merged
Conversation
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Unisay
reviewed
Mar 10, 2025
Unisay
reviewed
Mar 10, 2025
| -- | Convert the `Map` to a `P.BuiltinList` of key-value pairs. This operation is O(1). | ||
| toBuiltinList :: Map k a -> BI.BuiltinList (BI.BuiltinPair BuiltinData BuiltinData) | ||
| toBuiltinList (Map d) = d | ||
| toBuiltinList = coerce |
Contributor
There was a problem hiding this comment.
Given that Map is a newtype and as such is representationally equal to its internals, does this change make any difference?
Contributor
Author
There was a problem hiding this comment.
Yes because I'm not binding the variable
Unisay
reviewed
Mar 10, 2025
zliu41
approved these changes
Mar 10, 2025
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6777
The SOP Plutus Ledger API currently uses a
MintValuetype. This PR brings the two APIs in sync. It also renames and adds transformation functions fromData.Mapto the various list types.